fix(web): stop question answers from resetting the editor caret by shivamhwp · Pull Request #11337 · pingdotgg/t3code

shivamhwp · 2026-09-11T23:16:13Z

Selecting a skill in a pending question answer can leave the picker stuck and trigger Maximum call stack size exceeded. The answer callback reads the old editor snapshot and resets the caret before the new answer has rendered, re-entering Lexical with stale token offsets.

Let the editor retain its selection when reporting an answer change. Picker replacements already schedule their own caret placement. This removes the extra snapshot read and focus reset.

Refs #7805. This fixes the reproduced recursion and caret corruption; it preserves the existing skill picker. The broader request to make question answers plain text remains open. Rebased onto main.

Native Electron verification with two synthetic pending questions: the base leaves $bro unconverted, keeps 12 picker options open, and logs a stack overflow. The fix creates the Bro chip, closes the picker, and reports no errors. Typing/backspace works; Next starts empty, Previous preserves the first answer, and removing the request restores the original draft. No final answer was submitted to a provider. Web typecheck and 36 existing editor/answer tests pass; scoped lint exactly matches 17 base warnings.

Before/after images and video are captured. GitHub asset upload remains pending while its background browser connection is unavailable.

Model: GPT-6. Harness: Codex.

Rebased on main 20363c32c9bfdbf49c2716ef11d1f18483fcc01b. Scoped validation rerun after rebasing; existing native and human review limits remain.

Summary by CodeRabbit

Bug Fixes
- Improved chat composer behavior by allowing the editor to retain control of focus and cursor position when entering custom answers.

cursor · 2026-09-11T23:16:17Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

macroscopeapp · 2026-09-11T23:17:45Z

Approvability

Verdict: Approved at a0e60a4

Macroscope's review found this PR approvable — This is a small, self-contained web bug fix that preserves answer updates while removing a stale caret repositioning side effect. It introduces no new capability, schema, configuration, or sensitive-data behavior.

No code changes detected at 7caa53a. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

github-actions · 2026-09-11T23:18:46Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.6 KiB	+21 B (+0.2%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.1 KiB	+1 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+20 B (+0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	8	8	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.5 KiB	−70 B (−0.5%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.1 KiB	7.0 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.5 KiB	−63 B (−0.9%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	57.8 KiB	−88 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	10	8	−2 (−20.0%)	21	✅

Baseline: e628683 · PR result: 7caa53a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.9 KiB
Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

cursor · 2026-09-13T15:40:08Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

coderabbitai · 2026-09-13T15:43:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 08f9828f-6b22-421b-bf3c-f5869aba46f8

📥 Commits

Reviewing files that changed from the base of the PR and between 20363c3 and ce4c22f.

📒 Files selected for processing (1)

apps/web/src/components/ChatView.tsx

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

Walkthrough

The pending custom-answer callback now accepts only the question ID and answer value. Cursor metadata, snapshot comparison, and composer focus restoration were removed. The editor retains selection-state management.

Changes

Composer Selection Ownership

Layer / File(s)	Summary
Simplify custom-answer callback `apps/web/src/components/ChatView.tsx`	The callback no longer receives cursor metadata or restores composer focus and selection. The editor manages selection state directly.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 7caa5

This focused change removes redundant caret handling without evidence of a regression, so it is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main fix: preventing question answers from resetting the editor caret.
Description check	✅ Passed	The description explains what changed, why the change is needed, validation results, and UI evidence. It does not use the template headings or checklist, but it provides the required information and r…

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/web-question-answer-caret

_{Comment @coderabbitai help to get the list of available commands.}

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 11, 2026

macroscopeapp Bot approved these changes Sep 11, 2026

View reviewed changes

shivamhwp force-pushed the fix/web-question-answer-caret branch from a0e60a4 to ce4c22f Compare September 13, 2026 15:40

shivamhwp changed the base branch from fix/client-device-ticket-http-group to main September 13, 2026 15:40

github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. and removed size:S 10-29 changed lines (additions + deletions). labels Sep 13, 2026

fix(web): stop question answers from resetting the editor caret

7caa53a

shivamhwp force-pushed the fix/web-question-answer-caret branch from ce4c22f to 7caa53a Compare September 13, 2026 16:00

github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XXL 1,000+ changed lines (additions + deletions). labels Sep 13, 2026

Navigation Menu

Uh oh!

fix(web): stop question answers from resetting the editor caret - #11337

fix(web): stop question answers from resetting the editor caret#11337
shivamhwp wants to merge 1 commit into
mainfrom
fix/web-question-answer-caret

shivamhwp commented Sep 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

cursor Bot commented Sep 11, 2026

Uh oh!

macroscopeapp Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 11, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Sep 13, 2026

Uh oh!

coderabbitai Bot commented Sep 13, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

shivamhwp commented Sep 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

cursor Bot commented Sep 11, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

macroscopeapp Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

github-actions Bot commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thread transfer impact

Uh oh!

cursor Bot commented Sep 13, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

coderabbitai Bot commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shivamhwp commented Sep 11, 2026 •

edited by coderabbitai Bot

Loading

macroscopeapp Bot commented Sep 11, 2026 •

edited

Loading

github-actions Bot commented Sep 11, 2026 •

edited

Loading

coderabbitai Bot commented Sep 13, 2026 •

edited

Loading